Skip to content

Bug fixes for namelist reads in LAND IAU and UGWP code#1183

Merged
grantfirl merged 2 commits intoNCAR:mainfrom
climbfuji:bugfixes/lnd_iau_and_cires_ugwp_namelist_reads
Jan 28, 2026
Merged

Bug fixes for namelist reads in LAND IAU and UGWP code#1183
grantfirl merged 2 commits intoNCAR:mainfrom
climbfuji:bugfixes/lnd_iau_and_cires_ugwp_namelist_reads

Conversation

@climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 31, 2025 •
edited
Loading

Description of Changes:

This PR addresses issue #1182

  • by closing the namelist file in lnd_iau_mod_set_control if the land iau section is not found and INTERNAL_FILE_NML is not used,
  • and by checking that the file open call in cires_ugwpv0_mod_init is successful; if not, it returns with an appropriate error message and error code following CCPP requirements

Tests Conducted:

Tested in NEPTUNE

Dependencies:

None

Documentation:

n/a

Issue (optional):

Closes #1182

Contributors (optional):

n/a

@climbfuji climbfuji self-assigned this Dec 31, 2025
@climbfuji climbfuji marked this pull request as ready for review December 31, 2025 14:52
grantfirl
grantfirl approved these changes Jan 23, 2026
View reviewed changes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I need to test before merging.

@grantfirl
Copy link
Collaborator

grantfirl commented Jan 23, 2026

@climbfuji @matusmartini I will probably want to combine this with #1188 and #1189 for testing in UFS/SCM. I'm not seeing any code changes in all of these PRs that will actually change results. Is that your expectation?

@climbfuji
Copy link
Collaborator Author

climbfuji commented Jan 23, 2026

@climbfuji @matusmartini I will probably want to combine this with #1188 and #1189 for testing in UFS/SCM. I'm not seeing any code changes in all of these PRs that will actually change results. Is that your expectation?

Certainly not for this PR and 1189. I am happy to create a wrapper PR for all three and do the testing for you in the UFS if that helps.

@grantfirl
Copy link
Collaborator

grantfirl commented Jan 23, 2026

@climbfuji @matusmartini I will probably want to combine this with #1188 and #1189 for testing in UFS/SCM. I'm not seeing any code changes in all of these PRs that will actually change results. Is that your expectation?

Certainly not for this PR and 1189. I am happy to create a wrapper PR for all three and do the testing for you in the UFS if that helps.

Sure, that would be great, although the NCAR fork is behind by one PR (ufs-community#298). You may want to wait to test in UFS until I/we get this merged in to the NCAR branch.

@climbfuji
Copy link
Collaborator Author

climbfuji commented Jan 23, 2026

@climbfuji @matusmartini I will probably want to combine this with #1188 and #1189 for testing in UFS/SCM. I'm not seeing any code changes in all of these PRs that will actually change results. Is that your expectation?

Certainly not for this PR and 1189. I am happy to create a wrapper PR for all three and do the testing for you in the UFS if that helps.

Sure, that would be great, although the NCAR fork is behind by one PR (ufs-community#298). You may want to wait to test in UFS until I/we get this merged in to the NCAR branch.

Not a problem. I can create the wrapper here, and then test in the UFS in a branch that is based on the ufs-community code with the wrapper pulled in.

@climbfuji climbfuji mentioned this pull request Jan 26, 2026
Merged
@climbfuji
Copy link
Collaborator Author

climbfuji commented Jan 26, 2026

@climbfuji @matusmartini I will probably want to combine this with #1188 and #1189 for testing in UFS/SCM. I'm not seeing any code changes in all of these PRs that will actually change results. Is that your expectation?

Certainly not for this PR and 1189. I am happy to create a wrapper PR for all three and do the testing for you in the UFS if that helps.

Sure, that would be great, although the NCAR fork is behind by one PR (ufs-community#298). You may want to wait to test in UFS until I/we get this merged in to the NCAR branch.

Not a problem. I can create the wrapper here, and then test in the UFS in a branch that is based on the ufs-community code with the wrapper pulled in.

@grantfirl See #1191. I pulled this into the current ufs-develop code and ran the regression tests on Ursa; all tests pass (/scratch3/BMC/gmtb/Dom.Heinzeller/ccpp_phys_wrapper_1183_1188_1189_ufs_community/).

grantfirl added a commit that referenced this pull request Jan 28, 2026
@grantfirl
Merge pull request #1191 from climbfuji/feature/wrapper_1183_1188_118…
52a9db3 
…9_ncar

Wrapper PR for #1183 #1188 #1189 (NRL cleanup PRs)
@grantfirl grantfirl merged commit ff19404 into NCAR:main Jan 28, 2026
3 checks passed
@climbfuji climbfuji deleted the bugfixes/lnd_iau_and_cires_ugwp_namelist_reads branch January 29, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantfirl grantfirl grantfirl approved these changes

@mdtoyNOAA mdtoyNOAA Awaiting requested review from mdtoyNOAA mdtoyNOAA is a code owner

@rhaesung rhaesung Awaiting requested review from rhaesung rhaesung is a code owner

@dustinswales dustinswales Awaiting requested review from dustinswales dustinswales is a code owner

Assignees

@climbfuji climbfuji

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bugs in land_iau_mod_set_control and cires_ugwpv0_mod_init related to namelist reads

2 participants

@climbfuji @grantfirl